Skip to content
This repository was archived by the owner on Jun 11, 2026. It is now read-only.

Make the columns scroll separately#21

Merged
nking-1 merged 3 commits into
devfrom
scrolling-columns
May 26, 2021
Merged

Make the columns scroll separately#21
nking-1 merged 3 commits into
devfrom
scrolling-columns

Conversation

@nking-1

@nking-1 nking-1 commented May 25, 2021

Copy link
Copy Markdown

The columns will now scroll independently instead of forcing you to scroll the entire page.

image

@nking-1
nking-1 requested review from ilmarinen and jlema May 25, 2021 23:45
@nking-1
nking-1 force-pushed the scrolling-columns branch from e410600 to ef7979a Compare May 26, 2021 00:00
Comment thread frontend/MainContainer.tsx Outdated
generateText,
selectText
}) => {
const [isFolded, setIsFolded] = useState(false);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redux state for now please, if you need it to be external to the component. Otherwise local state component.

@jlema jlema added the enhancement New feature or request label May 26, 2021
@jlema jlema added this to the Eric Demo milestone May 26, 2021

@ilmarinen ilmarinen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nking-1
nking-1 merged commit 92fdaa1 into dev May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants